-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ipfs.cyou #579
feat: add ipfs.cyou #579
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
@@ -1,4 +1,5 @@ | |||
[ | |||
"https://ipfs.cyou", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smurfix I think you need to fix TLS setup. Currently, you have wildcard at wrong place:
TLS wildcards work only for one level up. Due to this, you need to set up additional TLS wildcard certificates for DNS Names one subdomain higher: *.ipfs.ipfs.cyou
and *.ipns.ipfs.cyou
.
See https://docs.ipfs.tech/how-to/address-ipfs-on-web/#subdomain-gateway
You can reproduce with below:
- https://ipfs.cyou/ipfs/bafkreibm6jg3ux5qumhcn2b3flc3tyu6dmlb4xa7u5bf44yegnrjhc4yeq redirects to https://bafkreibm6jg3ux5qumhcn2b3flc3tyu6dmlb4xa7u5bf44yegnrjhc4yeq.ipfs.ipfs.cyou which then fails due to TLS error
- https://ipfs.cyou/ipns/en.wikipedia-on-ipfs.org redirects to https://en-wikipedia--on--ipfs-org.ipns.ipfs.cyou which then fails due to TLS error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm already working on it. Unfortunately my DNS secondaries sometimes decide not to listen to update notifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, now uses working wildcard certificates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cert issues look to be cleared up. https://specs-ipfs-tech.ipns.ipfs.cyou/ works and so does bafkreibm6jg3ux5qumhcn2b3flc3tyu6dmlb4xa7u5bf44yegnrjhc4yeq.ipfs.ipfs.cyou
## [1.12.0](v1.11.0...v1.12.0) (2024-08-29) ### Features * add ipfs.cyou ([#579](#579)) ([66cb2f7](66cb2f7))
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is a well-connected server in Nürnberg Germany. Free bandwidth limited based on usage; faster paid access will be added later this year.